Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-3771: bump Storybook version to latest in plasma-new-hope #1678

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

PLASMA-3771: bump Storybook version to latest in plasma-new-hope #1678

wants to merge 1 commit into from
+2,932 −14,412

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Dec 24, 2024 •
edited by Salute-Eva
Loading

PLASMA-NEW-HOPE

  • обновлена версия пакета storybook до latest (только для new-hope)
  • внесены изменения, сопутствующие обновлению

What/why changed

Версия storybook в пакете new-hope поднята до 8.4.7

AFTER

Storybook_After
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1678/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-1678/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1678/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1678/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-1678/giga-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1678/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1678/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1678/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1678/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1678/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1678/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1678/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1678/ui-storybook/

denivladislav
denivladislav commented Dec 28, 2024
View reviewed changes
packages/plasma-new-hope/.storybook/main.ts
@@ -34,7 +34,6 @@ const config: StorybookConfig = {
disableTelemetry: true,
},
docs: {
autodocs: true,
Copy link
Contributor Author

@denivladislav denivladislav Dec 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Изменение в связи с autoupdate – опция autodocs переехала в preview.ts

denivladislav
denivladislav commented Dec 28, 2024
View reviewed changes
packages/plasma-new-hope/.storybook/manager.js
@@ -1,4 +1,4 @@
import { addons } from '@storybook/addons';
import { addons } from '@storybook/manager-api';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addons устарели:

https://storybook.js.org/docs/addons/addon-migration-guide#removal-of-deprecated-features

@denivladislav denivladislav changed the title DRAFT: chore(plasma-new-hope): bump Storybook version to latest chore(plasma-new-hope): bump Storybook version to latest Dec 28, 2024
@denivladislav denivladislav changed the title chore(plasma-new-hope): bump Storybook version to latest PLASMA-3771: bump Storybook version to latest in plasma-new-hope Dec 28, 2024
@denivladislav denivladislav self-assigned this Jan 9, 2025
denivladislav
denivladislav commented Jan 9, 2025
View reviewed changes
packages/plasma-new-hope/.storybook/main.ts
Comment on lines +39 to +41
typescript: {
reactDocgen: false,
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выставил в false в связи с возникновением аналогичной проблемы:

storybookjs/storybook#28350 (comment)

denivladislav
denivladislav commented Jan 9, 2025
View reviewed changes
packages/plasma-new-hope/src/examples/_helpers.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Изменения связаны с внутренними изменениями типов ArgTypes

denivladislav
denivladislav commented Jan 9, 2025
View reviewed changes
packages/plasma-new-hope/vite.config.js Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Теперь конфиг для vite необходимо создавать явно:

https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#for-react

@denivladislav denivladislav marked this pull request as ready for review January 13, 2025 08:22
@github-actions github-actions bot requested review from shuga2704 and TitanKuzmich and removed request for Yeti-or, Yakutoc, neretin-trike, TitanKuzmich and shuga2704 January 13, 2025 08:22
@denivladislav denivladislav requested a review from Yakutoc January 13, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@shuga2704 shuga2704 Awaiting requested review from shuga2704 shuga2704 is a code owner

@Yakutoc Yakutoc Awaiting requested review from Yakutoc Yakutoc is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@denivladislav denivladislav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denivladislav @TitanKuzmich